Opened 22 months ago

Closed 13 months ago

Last modified 5 months ago

#6328 closed change (fixed)

Move all icons into skin/icons directory in adblockplusui

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6327, #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/149
https://gitlab.com/eyeo/adblockplus/abpui/adblockpluschrome/merge_requests/9

Description (last modified by greiner)

Background

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/205

What to change

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/205

Notes for dependency update

Update mapping for the following files:

  • skin/mobile/* to skin/icons/mobile/*
  • skin/social/* to skin/icons/*
  • skin/updates/icon-* to skin/icons/updates/*
  • skin/abb-logo.png to skin/icons/abb-logo.png
  • skin/abp-64.png to skin/icons/abp-64.png
  • skin/abp-128.png to skin/icons/abp-128.png
  • skin/abp-logo.svg to skin/icons/abp-logo.svg

Hints for testers

None of the following images should be missing.

Extension:

  • 128px extension logo and toolbar icon

Block element dialog:

  • Adblock Plus logo

Bubble UI:

  • Adblock Plus logo

Desktop options page:

  • Adblock Plus logo
  • Facebook, Google+ and Twitter icons in Help tab

Issue reporter:

  • Adblock Plus logo

Mobile options page:

  • Adblock Plus logo
  • Checkmark icon in "Add filter list" dialog
  • Toggle button

Updates page:

  • Adblock Plus logo
  • Background image
  • Feature icons

Change History (9)

comment:1 Changed 22 months ago by greiner

  • Description modified (diff)

Added further changes and notes for dependency update.

comment:2 Changed 14 months ago by greiner

  • Description modified (diff)
  • Summary changed from Reorganize social images in adblockplusui to Move all icons into skin/icons directory in adblockplusui

Updated ticket to move all icons to the icons directory.

comment:3 Changed 14 months ago by greiner

See also #6331.

comment:4 Changed 13 months ago by greiner

  • Owner set to greiner

comment:5 Changed 13 months ago by greiner

  • Blocking 6936 added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 13 months ago by greiner

  • Description modified (diff)

Added hints for testers.

comment:8 Changed 6 months ago by abpbot

A commit referencing this issue has landed:
Issue 6328 - Moved all icons into skin/icons directory

comment:9 Changed 5 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.