#6329 closed change (fixed)

Add support for $csp filter option to core

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Core Keywords:
Cc: sergz, sebastian, mjethani, hfiguiere, mapx, fanboy, arthur Blocked By:
Blocking: #5241 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29680684/
https://codereview.adblockplus.org/29680689/

Description

Background

For #5241 we're adding support for the $csp filter option to adblockpluschrome, but before we can do that we need to add the filter option to the core code.

What to change

  • Modify the filter code so that filters can contain whitespaces where necessary, since whitespace is significant in Content Security Policies.
  • Add the $csp filter option itself, make sure it's not enabled by default. If the value includes "report-to" throw an "filter_invalid_csp" InvalidFilter.

Change History (4)

comment:1 Changed 22 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 22 months ago by arthur

  • Cc arthur added

comment:3 Changed 20 months ago by abpbot

A commit referencing this issue has landed:
Issue 6329 - Add the CSP filter option

comment:4 Changed 20 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.