Opened 4 months ago

Closed 4 months ago

Last modified 3 months ago

#6335 closed change (fixed)

[ABP for Samsung Internet] - Update translations for "Samsung Internet"

Reported by: Shikitita Assignee: jwangenheim
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.3
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: jwangenheim, mario Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29687593/

Description

Background

When we launched ABP for Samsung Internet, the official translation for "Samsung Internet" was "Samsung Internet" in all languages except Korean. However, it seems this is no longer the case.

What to change

"Samsung Internet" has been translated into Italian, Russian and Spanish and therefore should be updated in the relevant strings for ABP for Samsung Internet.

The new text is as follows:

Italian: Internet Samsung
Russian: Интернет Samsung
Spanish: Internet de Samsung

The affected strings would be:

app_name
sbrowser_dialog_title
sbrowser_dialog_message
setup_dialog_title
setup_dialog_message_sbrowser_4
setup_dialog_message_sbrowser_5
setup_dialog_button

Change History (6)

comment:1 Changed 4 months ago by jwangenheim

  • Owner set to jwangenheim

comment:2 Changed 4 months ago by abpbot

A commit referencing this issue has landed:
Issue 6335 - Update translations for 'Samsung Internet'

comment:3 Changed 4 months ago by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 months ago by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 months ago by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.3

comment:6 Changed 3 months ago by rscott

  • Verified working set
Note: See TracTickets for help on using tickets.