Opened 16 months ago

Last modified 8 months ago

#6357 new change

Don't suggest element hiding filters if we can't hide elements on the page

Reported by: greiner Assignee:
Priority: P3 Milestone:
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

Using the "Block element" feature we allow the use to create filters to block or hide elements on the page.

However, there are situations when the extension doesn't add its styles because either element hiding is disabled by a filter or we cannot apply element hiding rules to the page (e.g. #1770). Disabling the feature altogether for such pages (as we do for non-HTTP(S) pages) is not a solution though because request filters still work.

What to change

Don't suggest any element hiding filters in the "Block element" dialog if we cannot apply element hiding rules to the page and allow the UI to show a message explaining why.

Change History (2)

comment:1 Changed 8 months ago by greiner

  • Description modified (diff)
  • Summary changed from Don't suggest element hiding filters if we can't create a shadow root to Don't suggest element hiding filters if we can't hide elements on the page

Updated ticket to make it independent of how element hiding rules are applied.

comment:2 Changed 8 months ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set
Note: See TracTickets for help on using tickets.