Opened 22 months ago

Closed 3 months ago

#6357 closed change (rejected)

Don't suggest element hiding filters if we can't hide elements on the page

Reported by: greiner Assignee:
Priority: P3 Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: kzar, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

Using the "Block element" feature we allow the use to create filters to block or hide elements on the page.

However, there are situations when the extension doesn't add its styles because either element hiding is disabled by a filter or we cannot apply element hiding rules to the page (e.g. #1770). Disabling the feature altogether for such pages (as we do for non-HTTP(S) pages) is not a solution though because request filters still work.

What to change

Don't suggest any element hiding filters in the "Block element" dialog if we cannot apply element hiding rules to the page and allow the UI to show a message explaining why.

Change History (3)

comment:1 Changed 14 months ago by greiner

  • Description modified (diff)
  • Summary changed from Don't suggest element hiding filters if we can't create a shadow root to Don't suggest element hiding filters if we can't hide elements on the page

Updated ticket to make it independent of how element hiding rules are applied.

comment:2 Changed 14 months ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 3 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.