Opened 16 months ago

Last modified 8 months ago

#6358 new defect

Correct resource URL colours for dark theme version of our developer tools panel

Reported by: kzar Assignee:
Priority: P3 Milestone:
Module: User-Interface Keywords: goodfirstbug
Cc: greiner, mapx, jeen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Environment

Unknown version of Chrome, with developer tools set to dark theme.
Uknown version of Adblock Plus.

How to reproduce

  1. Open the developer tools for a tab, switch to the Adblock Plus pane.
  2. Browse to https://adblockplus.org in the tab.

Observed behaviour

The resource URLs listed in the Adblock Plus developer tools pane are extremely hard to read - dark grey on grey.

Expected behaviour

The URLs are easier to read.

What to change

Improve dark theme support in our DevTools panel by using colors with better contrast for texts, links, backgrounds and other UI elements.

See ui#194.

Notes

  • Perhaps we should reevaluate all the colours used for the dark theme version, since I just picked those (#4136) and I'm no designer.
  • This was probably made worse by my changes for #6035 (turning the URLs into links).
  • This issue is based on a report in the forum which mapx highlighted.

Change History (6)

comment:1 Changed 16 months ago by kzar

  • Description modified (diff)

comment:2 Changed 16 months ago by kzar

  • Description modified (diff)

comment:3 Changed 16 months ago by greiner

  • Cc jeen added
  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

We don't have a spec for the DevTools panel yet which defines overall design and user experience. It definitely makes sense to have one at some point, I just feel that it's not as critical as other UIs that we still need to add to the spec (e.g. icon popup).

That being said, we can already work on improving our dark theme support for all supported browsers because there's also some improvements we should make for Firefox.

@Jeen Feel free to disagree.

comment:4 Changed 16 months ago by greiner

  • Keywords goodfirstbug added

comment:5 Changed 8 months ago by greiner

  • Ready unset

We now have a spec for the DevTools panel but don't mention the support for the dark theme there yet. Therefore I agree that it may indeed be best to design the dark theme from scratch rather than basing it on what we currently have.

comment:6 Changed 8 months ago by greiner

  • Description modified (diff)

Added link to corresponding GitLab issue.

Note: See TracTickets for help on using tickets.