#6361 closed change (fixed)

Make all strings localizable in the action extension

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: #6261 Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29690946/

Description (last modified by dzhang)

Background

For translations, strings need to be available for export. There are a couple problems with the action extension.

  1. Extraneous placeholders are present (i.e. CNN website)
  2. Attributed strings used in the storyboard are not exported for translation.

What to change

  • Remove extraneous placeholders
  • Make attributed strings available for translation

Change History (3)

comment:1 Changed 22 months ago by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 22 months ago by dzhang

  • Description modified (diff)

comment:3 Changed 22 months ago by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.