Opened 9 months ago

Closed 7 months ago

#6371 closed change (fixed)

Move hosting of beta versions of Adblock Plus for Firefox back to a self-hosted solution

Reported by: tlucas Assignee: tlucas
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: fhd, sebastian, matze, sergz Blocked By:
Blocking: #6381 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29716693/

Description (last modified by tlucas)

Background

Mozilla removes the feature to host beta versions of extensions @ AMO, the currently aimed deployment of this change happens on Feb 22nd '18.
We currently use this feature and have to adapt to continue providing beta versions for our users. Extensions STILL need to be signed by AMO, in order to be installable in Firefox.

What to change

Resources for the aforementioned processes:

https://developer.mozilla.org/en-US/Add-ons/Distribution
http://addons-server.readthedocs.io/en/latest/topics/api/signing.html

  • change createNightlies.py in abpssembly to create and update an update-manifest https://downloads.adblockplus.org/devbuilds/adblockplusfirefox/updates.json for Adblock Plus for Firefox, always pointing to the latest version in https://downloads.adblockplus.org/devbuilds/adblockplusfirefox/, adhering to the following format:
    {
      "addons": {
        "devbuild@adblockplus.org": {
          "updates": [
            {"version": "<LATEST_VERSION>",
             "update_link": "<DOWNLOAD_LINK>" }
          ]
        }
      }
    }
    

Update the buildtools dependency to:

mercurial git
c830dfa08e2f 3a925dd

Included changes in buildtools

The list of changes imported by this is:

Ticket Summary Component
#6383 Overwrite ID and updateURL for Adblock Plus for Firefox when creating a non-release build Automation
#6037 Allow popup icons without popup Automation
#6021 Refactor build.py to use modern argparse Automation
#6020 Unnecessary code being included in webpack bundles Automation
#5997 Unit test files are included in the release build Automation
#5996 Let release automation create Firefox builds Automation
#5994 Release automation produces wrong commit Message Automation
#5939 Crowdin downloads suffixed translations to the wrong folder Automation
#5916 Locale strings are broken in adblockpluschrome when building from Windows Automation
#5915 adblockpluschrome won't build under Windows Automation
#5913 ensure_dependencies.py doesn't install Node.js dependencies on Windows Automation
#5877 First run page is missing some text Automation
#5844 [flake8-eyeo] Detect (more) redundant parentheses Automation


8ed981af2b75 Noissue - Drop support for Firefox 50 Manish Jethani
79688f4a4aff Noissue - Make comparable_xml safe against ambiguous tags Tristan Lucas
  • Relevant changes for this issue are #6021 and #6383
  • Relevant integration notes are found in #6021

Hints for testers

createNightlies should - besides the build-target gecko behave as before.

Note

This issue circular dependent on #6453

Change History (17)

comment:1 Changed 9 months ago by sebastian

You cannot have unlisted extensions on AMO. I think the way to go is self-distributing the development builds (after having them signed by AMO). This is also what Mozilla seems to recommend.

comment:2 Changed 9 months ago by fhd

Note that that's exactly how we currently distribute the Flattr extension, here's the relevant code: https://github.com/flattr/flattr-extension/blob/master/build/amo-upload.js

comment:3 Changed 8 months ago by tlucas

  • Description modified (diff)
  • Summary changed from Move hosting of beta versions of Adblock Plus for Firefox back to an on-premises solution to Move hosting of beta versions of Adblock Plus for Firefox back to a self-hosted solution

comment:4 Changed 8 months ago by tlucas

  • Owner set to tlucas
  • Priority changed from Unknown to P1
  • Ready set

comment:5 Changed 8 months ago by tlucas

  • Cc fhd sebastian matze added

comment:6 Changed 8 months ago by sergz

  • Cc sergz added

I saw in IRC that it could be eyeofiles for which a couple of projects are awaiting the configuration (basically proper securing of the server) for CI uploading, so I have added myself to CC to be aware if there is some progress in that direction.

comment:7 Changed 8 months ago by tlucas

  • Description modified (diff)

comment:8 Changed 8 months ago by tlucas

  • Blocking 6381 added

comment:9 Changed 8 months ago by tlucas

  • Blocking 6383 added

comment:10 Changed 8 months ago by tlucas

  • Description modified (diff)

comment:11 Changed 8 months ago by tlucas

  • Blocking 6383 removed

comment:13 Changed 8 months ago by tlucas

  • Description modified (diff)

comment:14 Changed 8 months ago by tlucas

  • Description modified (diff)

comment:15 Changed 8 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:16 Changed 7 months ago by abpbot

comment:17 Changed 7 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.