Opened 21 months ago

Closed 19 months ago

Last modified 18 months ago

#6373 closed change (fixed)

Remove calling GetHostFromURL()

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Rraceanu Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/6

Description (last modified by asmirnov)

Background

Because of #6372 we should avoid calling not required methods as they can take unpredictable time dependent on current state (updating/parsing/other JS methods invoking at the same time).

What to change

Remove calling GetHostFromURL() in chrome_network_delegate.cc

Change History (5)

comment:1 Changed 21 months ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 21 months ago by asmirnov

  • Description modified (diff)

comment:3 Changed 19 months ago by asmirnov

  • Review URL(s) modified (diff)

comment:4 Changed 19 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 18 months ago by rraceanu

  • Tester changed from Unknown to Rraceanu
  • Verified working set

No calls made to extract host/GetHostFromURL are being made on AdblockChromium dev-64.0.3249.2

Note: See TracTickets for help on using tickets.