#6377 closed change (fixed)

Enable testing push notifications with release and devbuild Xcode configurations

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29694555/

Description (last modified by dzhang)

Background

To switch between company and enterprise accounts, there are eight (8) changes to be made with the following values in parentheses:

Target AdblockPlusSafari

  • General > Bundle Identifier = (org.adblockplus.AdblockPlusSafari |

org.adblockplus.devbuilds.AdblockPlusSafari)

  • General > Team = (Company | Enterprise)
  • Capabilities > App Groups = (group.org.adblockplus.AdblockPlusSafari |

group.org.adblockplus.devbuilds.AdblockPlusSafari)

  • Edit scheme > Build Configuration = (Debug | Devbuild Debug)

Target AdblockPlusSafariActionExtension

  • General > Bundle Identifier = (org.adblockplus.AdblockPlusSafari.AdblockPlusSafariActionExtension | org.adblockplus.devbuilds.AdblockPlusSafari.AdblockPlusSafariActionExtension)
  • General > Team = (Company | Enterprise)

Target AdblockPlusSafariExtension

  • General > Bundle Identifier = (org.adblockplus.AdblockPlusSafari.AdblockPlusSafariExtension | org.adblockplus.devbuilds.AdblockPlusSafari.AdblockPlusSafariExtension)
  • General > Team = (Company | Enterprise)

It is required to use automatic signing to making switching configurations possible without additional changes. I attempted to change configurations using manual signing and was not able to build the project successfully. It appeared that many more changes to the build settings to account for the differences in the app IDs are needed without automatic signing.

Note that these configurations cannot be cleanly separated into a separate target because the product name _and_ module name is based on the target name. That would then require two separate imports for different modules.

What to change

  • Change project to use automatic signing
  • Enable the push notifications capability
  • Set default build configuration to be devbuild for push notification testing

Code for implementing push notifications will be part of another issue.

Change History (6)

comment:1 Changed 17 months ago by dzhang

  • Description modified (diff)

comment:2 Changed 17 months ago by dzhang

  • Description modified (diff)

comment:3 Changed 17 months ago by dzhang

  • Description modified (diff)

comment:4 Changed 17 months ago by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 17 months ago by dzhang

  • Description modified (diff)

comment:6 Changed 17 months ago by dzhang

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.