Opened 20 months ago

Closed 3 weeks ago

#6378 closed change (rejected)

[emscripten] Make DependentString constexpr

Reported by: sergz Assignee: rjeschke
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29722755/

Description

Background

We do use a certain number of string literals as a source for immutable DependentString and sometimes we have to introduce some fundamental helper functions like LENGTH_OF what can be avoided by constexpr variables and classes.

What to change

Change String and DependentString in accordance with the requirements to constexpr variables, functions and constructors and adjust the related variables in the code.
Consider removing the function (or macro what ever will be there later) LENGTH_OF mentioned above if it's not used anymore.

Change History (4)

comment:1 Changed 20 months ago by sergz

  • Priority changed from Unknown to P3

comment:2 Changed 19 months ago by rjeschke

  • Owner set to rjeschke

comment:3 Changed 19 months ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from reviewing to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.