Opened 10 months ago

Closed 8 months ago

Last modified 8 months ago

#6382 closed defect (fixed)

:-abp-contains() + div not working in Firefox

Reported by: arthur Assignee: hfiguiere
Priority: P1 Milestone:
Module: Platform Keywords:
Cc: hfiguiere, easylist.polish@…, mapx, amrmak, kzar, sebastian, Ross Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29723684/

Description

Environment

Windows 10
Firefox 58.0.2 (64 bits)
ABP 3.0.2.1969beta

How to reproduce

  1. Add wp.pl#?#div:-abp-contains(REKLAMA) + div as a custom rule to ABP
  2. Go to https://www.wp.pl/

Observed behaviour

Ad at the top below "REKLAMA" label doesn't disappear.

Expected behaviour

Ad at the top below "REKLAMA" label should disappear.

Notes

This seems to work fine in Chrome.

Change History (13)

comment:1 Changed 10 months ago by arthur

  • Cc easylist.polish@… added

comment:2 Changed 10 months ago by hfiguiere

  • Owner set to hfiguiere

For the record there is a better filter, but it require to have the fix for issue #6296:

wp.pl#?#:-abp-has(> div:-abp-contains(REKLAMA))

This one should work too.

Last edited 10 months ago by hfiguiere (previous) (diff)

comment:3 Changed 10 months ago by mapx

  • Cc mapx added

comment:4 Changed 10 months ago by hfiguiere

  • Keywords circumvention added

comment:5 Changed 9 months ago by amrmak

  • Cc amrmak added

comment:6 Changed 9 months ago by hfiguiere

Simpler test case:

Use filter testpages.adblockplus.org#?#h3:-abp-contains(Test case) + div
And then go to https://testpages.adblockplus.org/en/testcases/css/02

If "Test image" is visible then the filter isn't applied. Works fine in Chrome. Fail in Firefox.

comment:7 Changed 9 months ago by hfiguiere

  • Review URL(s) modified (diff)

comment:8 Changed 9 months ago by hfiguiere

  • Status changed from new to reviewing

comment:9 Changed 9 months ago by kzar

Fro the discussion in IRC this sounds like a recent regression. If so please could you add a note about that in the issue description, linking to the commit and explaining what happened?

comment:10 Changed 9 months ago by kzar

  • Cc kzar sebastian Ross added
  • Keywords circumvention removed
  • Priority changed from Unknown to P1
  • Ready set

comment:11 Changed 9 months ago by sebastian

From the discussion on IRC (see below), it actually doesn't seem to be a regression.

Posted on #adblockplus:

14:11:40 <_hub_> snoack: I believe it is not a regression

Sent to me privately:

14:27:59 <rossg> I see the same with 3.0.2. [...]


If it would be a regression, I'd agree with P1 and think that this should block the 3.0.3 release. Otherwise, P2 and aiming to fix this with Adblock Plus 3.1 should be fine.

Last edited 8 months ago by sebastian (previous) (diff)

comment:12 Changed 8 months ago by abpbot

comment:13 Changed 8 months ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.