Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#6383 closed change (fixed)

Overwrite ID and updateURL for Adblock Plus for Firefox when creating a non-release build

Reported by: tlucas Assignee: tlucas
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: sebastian, fhd, kvas Blocked By:
Blocking: #6453 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29696596/

Description (last modified by tlucas)

Background

In #6371 we want to self-host our extension for firefox again. For that to work, we need to provide a different extension ID and a different update-URL in the manifest.

What to change

Change mainfest.json.tmpl in buildtools to generate the following entries in the extensions manifest ONLY when no release-build is created, only when building for Firefox ( build.py build -t gecko ):

{
   "applications": {                                                             
     "gecko": {                                                                  
       "id": "devbuild@adblockplus.org",
       ...
     }                                                                           
   },
   ...
}

Note that "devbuild@…" is an arbitrary id, chosen by us.

Change History (7)

comment:1 Changed 3 months ago by tlucas

  • Blocked By 6371 added
  • Owner set to tlucas
  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed 3 months ago by tlucas

  • Description modified (diff)

comment:3 Changed 3 months ago by tlucas

  • Description modified (diff)

comment:4 Changed 3 months ago by tlucas

  • Description modified (diff)

comment:5 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 6383 - introduce switchable app_id

comment:6 Changed 3 months ago by tlucas

  • Blocked By 6371 removed
  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

comment:7 Changed 3 months ago by tlucas

  • Blocking 6453 added
Note: See TracTickets for help on using tickets.