#6392 closed change (fixed)

Fix capitalization and trim surrounding whitespace when adding to the whitelist

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29697686/

Description (last modified by dzhang)

Background

A host added to the users whitelisted does not get unblocked if the case is not lower case.

Extraneous whitespace may also be a problem when adding a host to the whitelist from user input.

What to change

  • Set the host name to all lowercase letters
  • Trim whitespace around the added host string

Change History (4)

comment:1 Changed 20 months ago by dzhang

  • Summary changed from Fix capitalization during adding host to whitelist and trim whitespace to Fix capitalization when adding a host to the whitelist and trim whitespace

comment:2 Changed 20 months ago by dzhang

  • Description modified (diff)
  • Summary changed from Fix capitalization when adding a host to the whitelist and trim whitespace to Fix capitalization and trim surrounding whitespace when adding to the whitelist

comment:3 Changed 20 months ago by dzhang

  • Review URL(s) modified (diff)

comment:4 Changed 20 months ago by dzhang

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.