Opened 16 months ago

Closed 7 months ago

Last modified 11 days ago

#6397 closed change (fixed)

Implement language dropdown

Reported by: greiner Assignee: agiammarchi
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: jeen Blocked By:
Blocking: #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/3
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/63

Description (last modified by greiner)

Background

The initial version of the new options page shipped without the drop-down field for selecting the default language but instead reuses the language selection dialog for that.

In an effort to finish up loose ends, we need to bring the implementation to the same state as the spec.

See also https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/84

What to change

https://gitlab.com/eyeo/specs/spec/merge_requests/175

Change History (15)

comment:1 Changed 16 months ago by agiammarchi

  • Owner set to agiammarchi

comment:2 Changed 16 months ago by saroyanm

  • Cc jeen added

@Jeen: can you please let us know if we still planing to use current widget, if so can you please update the link to link to the Gitlab version, because I can't find this widget there so far.

comment:3 Changed 16 months ago by agiammarchi

FYI there is an isolated implementation of the current bitbucket specs in here: https://webreflection.github.io/eyeo/tmp-listbox/

comment:4 Changed 16 months ago by jeen

  • Description modified (diff)

comment:5 Changed 16 months ago by jeen

Updated the link to the GitLab version.

comment:6 Changed 10 months ago by greiner

See also #5804.

comment:7 Changed 10 months ago by greiner

  • Description modified (diff)

Added links to GitLab issue and spec.

comment:8 Changed 9 months ago by greiner

  • Blocking 6936 added

comment:9 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 6397 - Implement language dropdown component

comment:10 Changed 7 months ago by greiner

  • Resolution set to fixed
  • Status changed from new to closed

comment:11 Changed 4 weeks ago by greiner

  • Review URL(s) modified (diff)

comment:12 Changed 4 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 6397 - Implement language dropdown

comment:13 Changed 4 weeks ago by kzar

  • Blocking 6936 removed

comment:14 Changed 4 weeks ago by kzar

  • Blocking 6936 added

comment:15 Changed 11 days ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.