Opened 19 months ago

Last modified 18 months ago

#6403 closed change

Update adblockplusui dependencies and metadata for options page launch — at Version 11

Reported by: saroyanm Assignee: greiner
Priority: P2 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: greiner, agiammarchi, wspee, kzar, sebastian, Ross Blocked By: #6336
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29664623/

Description (last modified by greiner)

Background

We are planing to introduce new options page to Chrome in addition to the Firefox build and also will roll out updates page.
To make it happen we need to update the adblockplusui dependency and update metadata accordingly.

What to change

  • Update adblockplusui dependency to {DEPENDENCY NUMBER}
  • Move Desktop and Mobile options page related mappings from metadata.gecko to metadata.chrome
  • Update fonts mapping according to the changes introduced in #6209
  • Add update page and resources introduced in #5943

Changes since last adblockplusui dependency update

Ticket Summary Component
#6316 Add translations for text "English" User-Interface
#6303 Introduce basic foundation for automation in adblockplusui User-Interface
#6297 Add translations from the agencies to the Adblock Plus update page User-Interface
#6209 Different font is used in some translations and Filter Lists table status column missalignment User-Interface
#6177 [ABP UI] Options Page - Overlapping of "Settings" translations User-Interface
#6089 SVG checkbox icon rendering issue User-Interface
#6009 Whitelisting (via options) fails in ABP 3.0 User-Interface
#6008 Add trigger to open Updates page Platform
#5943 Implement Updates Page for Adblock Plus extension User-Interface
#5873 Show information about bundled filter list in the Language Dialog User-Interface
#5813 Make new options page compatible with edge User-Interface


Hints for testers

New options page for Chrome

New options page on Chrome should work and look same as in Firefox, the only difference should be:

Update page

See related spec merge request.

Other

  • Please see "Changes since last adblockplusui dependency update" for more details.

Change History (11)

comment:1 Changed 19 months ago by saroyanm

  • Cc greiner agiammarchi wspee kzar sebastian Ross added
  • Component changed from Unknown to Platform
  • Description modified (diff)

This is yet blocked by the translation import and I'll push soon #6209.

@Thomas can you please update description accordingly for the Update Page changes if needed ? Maybe some hints for the testers and what to change section?

comment:2 in reply to: ↑ description Changed 19 months ago by saroyanm

Replying to saroyanm:

Background

We are planing to introduce new options page to Chrome and Edge in addition to the Firefox build and also will roll out updates page.

@Wspee, Are we going to launch the new options page for Edge as well ? Or plan is only Chrome for now ?

Last edited 19 months ago by saroyanm (previous) (diff)

comment:3 follow-up: Changed 19 months ago by wspee

Ultimately this should be rolled out to all platforms but we want to test it on chrome first using a partial roll out, once it has been rolled out to 100% on chrome we can release it everywhere.

comment:4 in reply to: ↑ 3 Changed 19 months ago by saroyanm

  • Description modified (diff)

Replying to wspee:

Ultimately this should be rolled out to all platforms but we want to test it on chrome first using a partial roll out, once it has been rolled out to 100% on chrome we can release it everywhere.

Acknowledged, updated the description accordingly.

Note: Make sense to ensure that the edge's inherited metadata from chrome.metadata doesn't include options page changes, but only old options page.

comment:5 follow-up: Changed 19 months ago by greiner

FWIW this is a duplicate of #6008. In hindsight we should've created this ticket instead of the other one but since the dependency update is already under review as part of https://codereview.adblockplus.org/29664623/ I'd suggest finishing that instead. It only needs to be updated to reflect the changes in #6209 as well as to include the upcoming translations.

comment:6 Changed 19 months ago by greiner

  • Description modified (diff)

Added link to updates page spec.

comment:7 in reply to: ↑ 5 ; follow-up: Changed 19 months ago by saroyanm

Replying to greiner:

FWIW this is a duplicate of #6008.

Noted

In hindsight we should've created this ticket instead of the other one but since the dependency update is already under review as part of https://codereview.adblockplus.org/29664623/ I'd suggest finishing that instead.

Fine with me, you want me update #6209 ticket description accordingly?

It only needs to be updated to reflect the changes in #6209 as well as to include the upcoming translations.

Also new options page and the note mentioned here I assume ? I can only see Updates Page relevant information there.

Update: Alternatively we can move the Codereview here. I feel like rolling options page to Chrome, but not Edge, might require additional updates.

Last edited 19 months ago by saroyanm (previous) (diff)

comment:8 in reply to: ↑ 7 ; follow-up: Changed 19 months ago by greiner

Replying to saroyanm:

Fine with me, you want me update #6209 ticket description accordingly?

What would you update? I usually add a section "Notes for dependency update" to a ticket to outline what changes it requires for a dependency update. Is that what you mean?

Also new options and the note mentioned here I assume ?

Yes, that as well.

Update: Alternatively we can move the Codereview here. I feel like rolling options page to Chrome, but not Edge, might require additional updates.

Fine with me. I'll close the other ticket then and move the review here.

comment:9 in reply to: ↑ 8 Changed 19 months ago by saroyanm

Replying to greiner:

Replying to saroyanm:

Fine with me, you want me update #6209 ticket description accordingly?

What would you update? I usually add a section "Notes for dependency update" to a ticket to outline what changes it requires for a dependency update. Is that what you mean?

Were planing to update information about the new options page, but since we are moving the review here, my comment is currently irrelevant.

comment:10 Changed 19 months ago by greiner

  • Owner set to greiner

Assigning myself and setting the ticket status to "codereview" to continue the work from #6008 as discussed. Note, however, that we still need to set the ticket to "ready" since the non-updates page related changes haven't been approved yet.

comment:11 Changed 19 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.