Opened 22 months ago

Closed 22 months ago

Last modified 21 months ago

#6412 closed change (fixed)

Update adblockpluscore dependency to revision 69a1ff0e91b3

Reported by: hfiguiere Assignee: hfiguiere
Priority: P2 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, fhd, kzar, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29705813/

Description (last modified by kzar)

Background

adblockpluscore has some bug fixes and improvement to filters. We should bring them to the next update.

Included changes are:

  • #6034 - :-abp-contains() accept a regular expression
  • #1846 - Remove the locale parameter of Notification.getLocalizedTexts
  • #6296 - Handle relative prefix in :-abp-has()
  • #5762 - Use relative require paths

What to change

Update the adblockpluscore dependency to hg:69a1ff0e91b3 git:a902e17.

Hints for testers

  • Test that :-abp-contains and :-abp-has are now working correctly - FIXME how?
  • Test that notifications are still localised correctly.
  • Test that the switch to relative require paths didn't break anything. Most files were touched, but it's enough to smoke test the stuff that was. Features to test include: element hiding (including emulation filters), request blocking, subscription updating, filter storage, whitelisting, notifications, subscription updating.

Change History (7)

comment:1 Changed 22 months ago by hfiguiere

  • Owner set to hfiguiere
  • Review URL(s) modified (diff)

comment:2 Changed 22 months ago by hfiguiere

  • Status changed from new to reviewing

comment:3 Changed 22 months ago by kzar

  • Cc Ross added
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed 22 months ago by abpbot

comment:5 Changed 22 months ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 22 months ago by hfiguiere

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:7 Changed 21 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Smoke test / general usage of build seems okay.

ABP 3.0.2.1983
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Note: See TracTickets for help on using tickets.