Opened on 02/22/2018 at 05:44:45 PM

Closed on 03/06/2018 at 01:45:29 PM

Last modified on 03/22/2018 at 01:55:35 PM

#6412 closed change (fixed)

Update adblockpluscore dependency to revision 69a1ff0e91b3

Reported by: hfiguiere Assignee: hfiguiere
Priority: P2 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, fhd, kzar, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by kzar)


adblockpluscore has some bug fixes and improvement to filters. We should bring them to the next update.

Included changes are:

  • #6034 - :-abp-contains() accept a regular expression
  • #1846 - Remove the locale parameter of Notification.getLocalizedTexts
  • #6296 - Handle relative prefix in :-abp-has()
  • #5762 - Use relative require paths

What to change

Update the adblockpluscore dependency to hg:69a1ff0e91b3 git:a902e17.

Hints for testers

  • Test that :-abp-contains and :-abp-has are now working correctly - FIXME how?
  • Test that notifications are still localised correctly.
  • Test that the switch to relative require paths didn't break anything. Most files were touched, but it's enough to smoke test the stuff that was. Features to test include: element hiding (including emulation filters), request blocking, subscription updating, filter storage, whitelisting, notifications, subscription updating.

Attachments (0)

Change History (7)

comment:1 Changed on 02/22/2018 at 06:58:41 PM by hfiguiere

  • Owner set to hfiguiere
  • Review URL(s) modified (diff)

comment:2 Changed on 02/22/2018 at 06:58:51 PM by hfiguiere

  • Status changed from new to reviewing

comment:3 Changed on 02/26/2018 at 12:54:33 PM by kzar

  • Cc Ross added
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed on 03/06/2018 at 01:44:23 PM by abpbot

comment:5 Changed on 03/06/2018 at 01:45:29 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 03/06/2018 at 05:47:39 PM by hfiguiere

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:7 Changed on 03/22/2018 at 01:55:35 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Smoke test / general usage of build seems okay.

Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Note: See TracTickets for help on using tickets.