Opened 22 months ago

Last modified 21 months ago

#6417 closed defect

empty error message for incorrect custom filters — at Version 5

Reported by: mapx Assignee:
Priority: P2 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: kzar, mjethani, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29709602/

Description (last modified by mapx)

Environment

ABP last dev build (FF / chrome) 3.0.2.1975
FF beta / chrome beta
windows 7 / windows 10

How to reproduce

add an incorrect custom filter

Observed behaviour

an error window opens having only the row number of the incorrect filter, no error message

Change History (6)

comment:1 Changed 22 months ago by mapx

  • Cc greiner added

comment:2 Changed 22 months ago by mapx

  • Component changed from Platform to User-Interface

comment:3 Changed 22 months ago by greiner

I wasn't able to reproduce this by adding the filter [ in the custom filter list. The filter is simply not added and no error message is shown (that's because #5549 is not included in this release yet).

Ubuntu 17.10
Chrome 64
Adblock Plus 3.0.2.1975

Which filter did you use to trigger that message?

Changed 22 months ago by mapx

comment:4 Changed 22 months ago by mapx

@@||example.com^$first-party

which obviously is not accepted by ABP (windows 7 / windows 10)

see attachment

Last edited 22 months ago by mapx (previous) (diff)

comment:5 Changed 22 months ago by mapx

  • Description modified (diff)
Note: See TracTickets for help on using tickets.