Opened on 02/26/2018 at 10:26:39 AM

Closed on 03/06/2018 at 06:08:14 PM

Last modified on 04/03/2018 at 02:00:05 PM

#6420 closed defect (fixed)

Whitelist filter notification shown on page load

Reported by: greiner Assignee: saroyanm
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: saroyanm, Ross, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



Ubuntu 17.10
Chrome 64
Adblock Plus

How to reproduce

  1. Open options page
  2. Add custom filter "foo"
  3. Add whitelisted website ""
  4. Reload page

Observed behaviour

The following notification is shown after adding the website to the whitelist as well as after each page reload:

"" has been whitelisted.

Expected behaviour

Notification should only be shown after adding a new website to the whitelist.

Further infomation

This issue occurs because of the global variable isCustomFiltersLoaded being set globally after the first custom filter list has been loaded. In this case, however, there are two custom filter lists.

Loading the first custom filter list (i.e. the one with the filter "foo" in it), sets isCustomFiltersLoaded = true. That means that when the second custom filter list (i.e. the one for whitelisted websites) is loaded, it appears as if a new filter got added which triggers the notification.

Attachments (0)

Change History (6)

comment:1 Changed on 03/01/2018 at 11:07:24 AM by saroyanm

  • Cc Ross added
  • Owner set to saroyanm

comment:2 Changed on 03/01/2018 at 11:21:28 AM by saroyanm

  • Cc kzar added

comment:3 Changed on 03/01/2018 at 12:23:52 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Thanks for noticing This Thomas, I think this should also be true for the Firefox.

comment:4 Changed on 03/06/2018 at 06:07:38 PM by abpbot

comment:5 Changed on 03/06/2018 at 06:08:14 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 04/03/2018 at 02:00:05 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set


Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Note: See TracTickets for help on using tickets.