Changes between Version 14 and Version 15 of Ticket #6428


Ignore:
Timestamp:
03/12/2019 05:34:45 PM (9 months ago)
Author:
jsonesen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6428

    • Property Status changed from new to reviewing
  • Ticket #6428 – Description

    v14 v15  
    33 
    44=== What to change === 
    5 Modify `getSelectorsForDomain` in lib/elemHide.js to provide exception filters which applied if the optional `withExceptions` argument was passed. 
     5Modify `generateStyleSheetForDomain` in lib/elemHide.js to provide exception filters which applied if the optional `withExceptions` argument was passed. 
    66 
    7 Note: The `getSelectorsForDomain` code is a hotspot, so we must be extremely careful when modifying it to avoid extra overhead when this new argument wasn't passed (see #4057). At the same time I'd like to avoid duplicating the entire function. One way to (roughly) profile the code is to run this snippet: 
     7Note: The `generateStyleSheetforDomain` code is a hotspot, so we must be extremely careful when modifying it to avoid extra overhead when this new argument wasn't passed (see #4057). At the same time I'd like to avoid duplicating the entire function. One way to (roughly) profile the code is to run this snippet: 
    88 
    99{{{ 
  • Ticket #6428 – Review URL(s)

    v14 v15  
     1https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/24