Changes between Version 14 and Version 15 of Ticket #6428
- Timestamp:
- 03/12/2019 05:34:45 PM (9 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #6428
- Property Status changed from new to reviewing
-
Ticket #6428 – Description
v14 v15 3 3 4 4 === What to change === 5 Modify `ge tSelectorsForDomain` in lib/elemHide.js to provide exception filters which applied if the optional `withExceptions` argument was passed.5 Modify `generateStyleSheetForDomain` in lib/elemHide.js to provide exception filters which applied if the optional `withExceptions` argument was passed. 6 6 7 Note: The `ge tSelectorsForDomain` code is a hotspot, so we must be extremely careful when modifying it to avoid extra overhead when this new argument wasn't passed (see #4057). At the same time I'd like to avoid duplicating the entire function. One way to (roughly) profile the code is to run this snippet:7 Note: The `generateStyleSheetforDomain` code is a hotspot, so we must be extremely careful when modifying it to avoid extra overhead when this new argument wasn't passed (see #4057). At the same time I'd like to avoid duplicating the entire function. One way to (roughly) profile the code is to run this snippet: 8 8 9 9 {{{ -
Ticket #6428 – Review URL(s)
v14 v15 1 https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/24