Changes between Initial Version and Version 5 of Ticket #6428


Ignore:
Timestamp:
05/10/2018 08:08:08 AM (2 years ago)
Author:
kzar
Comment:

Since we're already working on some changes to this code I've marked this as being blocked by #6652.

Replying to mjethani:

Do we have to include all exceptions or only one that matched (and prevented the filter's selector from getting added)?

Yea, just the one that matched is fine.

PS: By the way I would prefer if provideExceptionFilters were called withExceptions instead.

Fine by me.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6428

    • Property Cc jsonesen mjethani added
    • Property Owner set to jsonesen
    • Property Blocked By changed from to 6652

  • Ticket #6428 – Description

    initial v5  
    33 
    44=== What to change === 
    5 Modify `getSelectorsForDomain` in lib/elemHide.js to provide exception filters which applied if the optional `provideExceptionFilters` argument was passed. 
     5Modify `getSelectorsForDomain` in lib/elemHide.js to provide exception filters which applied if the optional `withExceptions` argument was passed. 
    66 
    77Note: The `getSelectorsForDomain` code is a hotspot, so we must be extremely careful when modifying it to avoid extra overhead when this new argument wasn't passed (see #4057). At the same time I'd like to avoid duplicating the entire function. One way to (roughly) profile the code is to run this snippet: