Opened 7 months ago

Closed 6 months ago

Last modified 4 months ago

#6431 closed change (fixed)

Remove old options page from adblockpluschrome

Reported by: greiner Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-3.1-for-Chrome-Opera-Firefox
Module: User-Interface Keywords:
Cc: wspee, saroyanm, agiammarchi, kzar, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29738601

Description (last modified by sebastian)

Background

As part of #6403 we have started using the new options page for all platforms that are supported by adblockpluschrome. That means that we can now safely remove any remnants of the old options page.

What to change

In adblockpluschrome:

  • Remove these files:
    • desktop-options.html
    • desktop-options.js
  • Remove these strings (note that the string "filters_subscription_lastDownload_connectionError" is also used for the issue reporter and should therefore not be removed):
    • add_domain_button
    • add_filter_button
    • add_your_own_filters
    • apply_changes
    • disabled_for_these_domains
    • edit_filters_raw
    • enable_only_the
    • filter_lists
    • filter_must_follow_syntax
    • filters_acceptableAds2_label
    • filters_addSubscription_label
    • filters_addSubscriptionAdd_label
    • filters_addSubscriptionOther_label
    • filters_readMore_label
    • filters_subscription_delete_label
    • filters_subscription_enabled_label
    • filters_subscription_lastDownload_checksumMismatch
    • filters_subscription_lastDownload_inProgress
    • filters_subscription_lastDownload_invalidData
    • filters_subscription_lastDownload_invalidURL
    • filters_viewList_label
    • found_a_bug
    • general
    • global_remove_subscription_warning
    • global_subscription_invalid_location
    • last_updated_at
    • last_updated_at_today
    • options
    • out_of_date_lists
    • overlay_shownotifications_label
    • remove_button
    • show_block_element_menu
    • show_devtools_panel
    • subscriptionSelection_location_label
    • subscriptionSelection_subscriptionSelector_label
    • subscriptionSelection_title_label
    • update_now
    • whitelisted_domains
  • Remove "composer.quoteCSS" messaging endpoint from lib/filterComposer.js

Change History (7)

comment:1 Changed 7 months ago by kzar

Well it's finally happening after all these years! Cool!

comment:2 Changed 7 months ago by greiner

  • Description modified (diff)

comment:3 Changed 6 months ago by sebastian

  • Description modified (diff)
  • Owner set to sebastian

It seems the string disabled_for_these_domains was also only used by the old options page. I added it to the list.

comment:4 Changed 6 months ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 6 months ago by abpbot

A commit referencing this issue has landed:
Issue 6431 - Removed old options page

comment:6 Changed 6 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 4 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Hasn't caused any regressions. Have not noticed any missing strings.

ABP 3.0.4.2042
Firefox 59 / 55 / 51 / Windows 10
Chrome 66 / 58 / 49 / Windows 7
Opera 52 / 45 / 36 / Windows 10

Note: See TracTickets for help on using tickets.