Opened 18 months ago

Closed 18 months ago

Last modified 17 months ago

#6451 closed change (fixed)

Adjust devtools panel to support $csp filters

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian, saroyanm, agiammarchi Blocked By:
Blocking: #5241 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29716584/

Description (last modified by kzar)

Background

With #5241 we're adding support for the $csp filter option which filter list authors can use to inject Content Security Policies for certain websites. Along with that we'll need to make some changes to our developer tools panel.

What to change

  • For CSP matches correct the exception rule added when clicking the "Add Exception" button. For example instead of adding the exception @@||reddit.com/ for *$csp=script-src 'none',domain=reddit.com it should add @@||reddit.com/$csp.

Change History (7)

comment:1 Changed 18 months ago by greiner

  • Cc saroyanm agiammarchi added
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 18 months ago by kzar

  • Description modified (diff)

I've just realised the request types drop down are now obtained from adblockpluschrome/lib/requestBlocker.js (#5316), I can adjust that with my changes for #5241.

comment:3 Changed 18 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 18 months ago by kzar

  • Owner set to kzar

comment:5 Changed 18 months ago by abpbot

A commit referencing this issue has landed:
Issue 6451 - Generate $csp exception filters properly

comment:6 Changed 18 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 17 months ago by Ross

Note: Cannot test just yet as $csp is currently not an accepted filter option in current devbuilds.

Note: See TracTickets for help on using tickets.