Opened on 03/07/2018 at 12:58:47 PM

Closed on 03/07/2018 at 03:22:12 PM

Last modified on 04/05/2018 at 10:45:28 AM

#6451 closed change (fixed)

Adjust devtools panel to support $csp filters

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian, saroyanm, agiammarchi Blocked By:
Blocking: #5241 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)


With #5241 we're adding support for the $csp filter option which filter list authors can use to inject Content Security Policies for certain websites. Along with that we'll need to make some changes to our developer tools panel.

What to change

  • For CSP matches correct the exception rule added when clicking the "Add Exception" button. For example instead of adding the exception @@|| for *$csp=script-src 'none', it should add @@||$csp.

Attachments (0)

Change History (7)

comment:1 Changed on 03/07/2018 at 01:37:47 PM by greiner

  • Cc saroyanm agiammarchi added
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 03/07/2018 at 01:54:10 PM by kzar

  • Description modified (diff)

I've just realised the request types drop down are now obtained from adblockpluschrome/lib/requestBlocker.js (#5316), I can adjust that with my changes for #5241.

comment:3 Changed on 03/07/2018 at 02:15:10 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 03/07/2018 at 02:15:20 PM by kzar

  • Owner set to kzar

comment:5 Changed on 03/07/2018 at 03:21:36 PM by abpbot

A commit referencing this issue has landed:
Issue 6451 - Generate $csp exception filters properly

comment:6 Changed on 03/07/2018 at 03:22:12 PM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 04/05/2018 at 10:45:28 AM by Ross

Note: Cannot test just yet as $csp is currently not an accepted filter option in current devbuilds.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.