Opened 21 months ago

Last modified 21 months ago

#6451 closed change

Adjust devtools panel to support $csp filters — at Version 2

Reported by: kzar Assignee:
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian, saroyanm, agiammarchi Blocked By:
Blocking: #5241 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29716584/

Description (last modified by kzar)

Background

With #5241 we're adding support for the $csp filter option which filter list authors can use to inject Content Security Policies for certain websites. Along with that we'll need to make some changes to our developer tools panel.

What to change

  • For CSP matches correct the exception rule added when clicking the "Add Exception" button. For example instead of adding the exception @@||reddit.com/ for *$csp=script-src 'none',domain=reddit.com it should add @@||reddit.com/$csp.

Change History (2)

comment:1 Changed 21 months ago by greiner

  • Cc saroyanm agiammarchi added
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 21 months ago by kzar

  • Description modified (diff)

I've just realised the request types drop down are now obtained from adblockpluschrome/lib/requestBlocker.js (#5316), I can adjust that with my changes for #5241.

Note: See TracTickets for help on using tickets.