#6460 closed change (fixed)

Prevent strings that are not to be localized from being exported

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: #6261 Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by dzhang)

Background

There are strings used that are being included in the localization export that do not require translation.

Examples are

  • "www.website.com"
  • "1."
  • "2."

A solution for setting their values while excluding them automatically using needs-translation (https://github.com/adblockplus/needs-translation)

What to change

  1. Prevent the values that will not be translated from being included during export of strings for translation.

Change History (4)

comment:1 Changed 20 months ago by dzhang

  • Blocking 6261 added

comment:2 Changed 20 months ago by dzhang

  • Description modified (diff)

comment:3 Changed 20 months ago by dzhang

The following exclusions should cover strings not to be translated.

const sourcesExcluded =
  [
    "$(PRODUCT_DISPLAY_NAME)",
    "$(PRODUCT_NAME)",
    "1.",
    "2.",
    "www.website.com"
  ];

comment:4 Changed 20 months ago by dzhang

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.