#6462 closed change (fixed)

Clear warnings for storyboard "You're in control" dialog and numeral labels

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29718595/

Description (last modified by dzhang)

Background

Three warnings are reported from the main storyboard that possibly arose from an update in Xcode.

  1. Auto Layout Localization: Trailing constraint is missing, which may cause overlapping with other views.
  1. Ambiguous Layout Group
  • 2 views are vertically ambiguous.
    • Height and vertical position are ambiguous for "Annoying ads are always blocked, while nonintrusive ads are displayed by default.
    • Height is ambiguous for "You're in control".
  1. Ambiguous Layout: Height and vertical position are ambiguous for "Acceptable Ads → Allow some nonintrusive ads".

What to change

Clear warnings using the following actions

  • Add trailing constraints for (2)
  • Make a container view for (3) and copy all controls into the container.

Change History (3)

comment:1 Changed 21 months ago by dzhang

  • Description modified (diff)

comment:2 Changed 21 months ago by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 21 months ago by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.