Opened on 03/13/2018 at 04:22:44 PM

Closed on 03/13/2018 at 11:17:16 PM

Last modified on 05/09/2018 at 11:11:27 AM

#6473 closed change (fixed)

Remove WebSocket wrapper

Reported by: mjethani Assignee: mjethani
Priority: Unknown Milestone: Adblock-Plus-3.1-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar Blocked By:
Blocking: #6459 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mjethani)


All supported versions of Firefox (51 onwards) support WebSocket blocking, while Chrome added support in version 58 (released April 19, 2017). As of now the WebSocket wrapper in the content script exists only for very outdated versions of Chrome.

See discussion on #6469.

What to change

Remove the WebSocket wrapper from inject.preload.js along with any related code and comments.

Attachments (0)

Change History (9)

comment:1 Changed on 03/13/2018 at 04:25:40 PM by mjethani

  • Description modified (diff)

comment:2 Changed on 03/13/2018 at 04:34:48 PM by mjethani

  • Review URL(s) modified (diff)

comment:3 Changed on 03/13/2018 at 11:15:34 PM by abpbot

A commit referencing this issue has landed:
Issue 6473 - Remove WebSocket wrapper

comment:4 Changed on 03/13/2018 at 11:16:55 PM by mjethani

  • Owner set to mjethani

comment:5 Changed on 03/13/2018 at 11:17:16 PM by mjethani

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed on 03/19/2018 at 04:51:41 PM by kzar

Since we have a release coming up and this was (correctly) pushed to the next branch I wonder if assigning the Adblock-Plus-for-Chrome-Opera-Firefox-next is right? Really the milestone should be Adblock-Plus-for-Chrome-Opera-Firefox-next-next, but that doesn't exist.

comment:7 Changed on 03/19/2018 at 05:36:50 PM by sebastian

That is correct. There is an Adblock-Plus-3.0.3-for Chrome-Opera-Firefox milestone with the changes for the upcoming release. The current Adblock-Plus-for-Chrome-Opera-Firefox-next milestone will eventually turn into the 3.0.4 release.

comment:8 Changed on 03/19/2018 at 05:51:38 PM by kzar

Cool OK, didn't realise you already moved the milestone on. That makes sense thanks.

comment:9 Changed on 05/09/2018 at 11:11:27 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. WebSocket blocking still works as expected. Except on Chrome < 58 (and Opera < 45), as described in #6469.

Firefox 59 / 55 / 51 / Windows 10
Chrome 66 / 58 / 49 / Windows 7
Opera 52 / 45 / 36 / Windows 10

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from mjethani.
Note: See TracTickets for help on using tickets.