Opened 16 months ago

Last modified 14 months ago

#6474 closed change

Enable pre-configured preferences through managed storage on Firefox — at Version 2

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-3.1-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: josue.mouco, Ross Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29721777

Description (last modified by sebastian)

Background

With Adblock Plus 2.6.10 for Firefox we started to allow suppressing the first run page through external configuration. This mechanism was specific to legacy Gecko extension, and when we migrated to WebExtensions with Adblock Plus 3.0, we had to leave that feature behind.

Now, Firefox 57 and above provides a mechanism to pre-configure WebExtensions, similar to Chrome. However, despite Adblock Plus for Chrome and Firefox being based on the same code, now, we specifically use that mechanism only on Chromium-based browsers.

I verified that removing this check, and saving following file in the resprective location (e.g. ~/.mozilla/managed-storage/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}.json), successfully suppresses the first run page, on Firefox 57 and above:

{
  "name": "{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}",
  "description": "Managed storage manifest for Adblock Plus",
  "type": "storage",
  "data": {
    "suppress_first_run_page": true
  }
}

Similarly, this change allows pre-configuration of additional default subscriptions (#3801):

{
  "name": "{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}",
  "description": "Managed storage manifest for Adblock Plus",
  "type": "storage",
  "data": {
    "additional_subscriptions": [
      "https://easylist-downloads.adblockplus.org/easyprivacy.txt"
    ]
  }
}

What to change

Read pre-configurable preferences from storage.managed on all platforms that support it.

Change History (2)

comment:1 Changed 16 months ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 16 months ago by sebastian

  • Description modified (diff)
Note: See TracTickets for help on using tickets.