Opened 21 months ago

Last modified 13 months ago

#6477 reopened change

Separate done and error callbacks in IFileSystem interface

Reported by: sergz Assignee:
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov Blocked By:
Blocking: #6452, #6537 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29731562/

Description (last modified by sergz)

Background

The current implementation of DefaultFileSystem can call the passed callback twice if there is an exception thrown from the callback, the second time it's called with the error message. It should not happen, the callback should be called exactly once.

What to change

Change the interface (with adding a comment) and implementation of DefaultFileSystem. Make the required adjustments.

Change History (12)

comment:1 Changed 21 months ago by sergz

  • Owner set to sergz

comment:2 Changed 21 months ago by sergz

  • Description modified (diff)

comment:3 Changed 21 months ago by sergz

  • Blocking 6452 added

comment:4 Changed 21 months ago by sergz

  • Review URL(s) modified (diff)

comment:5 Changed 21 months ago by sergz

  • Status changed from new to reviewing

comment:6 Changed 21 months ago by abpbot

comment:7 Changed 21 months ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 21 months ago by sergz

  • Resolution fixed deleted
  • Status changed from closed to reopened

Basically, all other functions should be addressed too, in particular Stat is very similar to Read.

comment:9 Changed 21 months ago by sergz

  • Owner sergz deleted

comment:10 Changed 21 months ago by sergz

  • Priority changed from P2 to P3

comment:11 Changed 19 months ago by oleksandr

  • Blocking 6537 added

comment:12 Changed 13 months ago by sergz

  • Cc asmirnov added
Note: See TracTickets for help on using tickets.