Opened 21 months ago

Closed 21 months ago

Last modified 20 months ago

#6488 closed defect (fixed)

Dependency update fails due to missing dependencies

Reported by: greiner Assignee: saroyanm
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: agiammarchi, saroyanm, wspee Blocked By:
Blocking: #6476 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29723665/

Description

Environment

Ubuntu 16.04
Node 8

How to reproduce

  1. Change adblockplusui dependency in adblockpluschrome to any revision that includes https://hg.adblockplus.org/adblockplusui/rev/b6f5a3ad7066
  2. Run ./build.py devenv -t chrome

Observed behaviour

The following warning is shown:

Warning: Mapped file adblockplusui/desktop-options.js doesn't exist

Expected behaviour

No such warnings are shown.

What to change

In package.json: Move dependencies that are required for "postinstall" hook from "devDependencies" to "dependencies".

Further information

We use npm's "postinstall" hook to automatically trigger the bundling of our JavaScript and CSS files whenever a dependency update is made. This step requires certain dependencies (i.e. eslint, browserify and others) but those aren't listed in package.json's "dependencies" but in "devDependencies". Therefore npm run bundle fails which means that no bundles are created.

Change History (7)

comment:1 Changed 21 months ago by saroyanm

Moving devDependencies to the dependencies doesn't fix the issue.

comment:2 Changed 21 months ago by saroyanm

Nevermind a user error, I'll upload a patch now.

comment:3 Changed 21 months ago by saroyanm

  • Owner set to saroyanm
  • Review URL(s) modified (diff)

comment:4 Changed 21 months ago by saroyanm

  • Status changed from new to reviewing

comment:5 Changed 21 months ago by abpbot

comment:6 Changed 21 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 20 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Looks fixed.

adblockpluschrome / 2002:97c946ed50bd

Note: See TracTickets for help on using tickets.