Opened on 03/15/2018 at 05:42:52 PM

Closed on 03/16/2018 at 10:49:21 AM

Last modified on 04/05/2018 at 08:27:17 AM

#6488 closed defect (fixed)

Dependency update fails due to missing dependencies

Reported by: greiner Assignee: saroyanm
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: agiammarchi, saroyanm, wspee Blocked By:
Blocking: #6476 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



Ubuntu 16.04
Node 8

How to reproduce

  1. Change adblockplusui dependency in adblockpluschrome to any revision that includes
  2. Run ./ devenv -t chrome

Observed behaviour

The following warning is shown:

Warning: Mapped file adblockplusui/desktop-options.js doesn't exist

Expected behaviour

No such warnings are shown.

What to change

In package.json: Move dependencies that are required for "postinstall" hook from "devDependencies" to "dependencies".

Further information

We use npm's "postinstall" hook to automatically trigger the bundling of our JavaScript and CSS files whenever a dependency update is made. This step requires certain dependencies (i.e. eslint, browserify and others) but those aren't listed in package.json's "dependencies" but in "devDependencies". Therefore npm run bundle fails which means that no bundles are created.

Attachments (0)

Change History (7)

comment:1 Changed on 03/15/2018 at 06:18:51 PM by saroyanm

Moving devDependencies to the dependencies doesn't fix the issue.

comment:2 Changed on 03/15/2018 at 07:06:35 PM by saroyanm

Nevermind a user error, I'll upload a patch now.

comment:3 Changed on 03/15/2018 at 07:11:09 PM by saroyanm

  • Owner set to saroyanm
  • Review URL(s) modified (diff)

comment:4 Changed on 03/15/2018 at 07:11:14 PM by saroyanm

  • Status changed from new to reviewing

comment:5 Changed on 03/16/2018 at 10:46:49 AM by abpbot

comment:6 Changed on 03/16/2018 at 10:49:21 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 04/05/2018 at 08:27:17 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Looks fixed.

adblockpluschrome / 2002:97c946ed50bd

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Note: See TracTickets for help on using tickets.