#6489 closed defect (fixed)

Initializing of scheduler in the DefaultPlatformBuilder does not allow to use it properly

Reported by: sergz Assignee: sergz
Priority: P1 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov, hfiguiere Blocked By:
Blocking: #6466 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29727558/

Description (last modified by sergz)

The way it's implemented right now one cannot use DefaultPlatformBuilder::GetDefaultAsyncExecutor for custom implementation of the interfaces because it's empty, the return value is created only when one calls DefaultPlatformBuilder::CreatePlatform, what should be the last call.

FYI, if one firstly calls DefaultPlatformBuilder::CreatePlatform then one cannot anymore set custom interfaces because it's already too late, the instance of Platform is created.

Change History (8)

comment:1 Changed 20 months ago by asmirnov

Also CreateDefaultFileSystem() requires defaultScheduler to be already created and it's created in CreatePlatform().
So it forces to call CreatePlatform() first.

Last edited 20 months ago by asmirnov (previous) (diff)

comment:2 Changed 20 months ago by asmirnov

  • Blocking 6466 added

comment:3 Changed 19 months ago by asmirnov

i've tested it with libadblockplus-android and it works now. Please submit code review asap

comment:4 Changed 19 months ago by sergz

  • Status changed from new to reviewing

comment:5 Changed 19 months ago by sergz

  • Review URL(s) modified (diff)

comment:6 Changed 19 months ago by sergz

  • Description modified (diff)

comment:8 Changed 19 months ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.