Changes between Initial Version and Version 1 of Ticket #6490, comment 9


Ignore:
Timestamp:
05/29/2018 11:03:57 PM (17 months ago)
Author:
jsonesen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6490, comment 9

    initial v1  
    11It seems we already catch errors in setIcon() for Edge [https://hg.adblockplus.org/adblockpluschrome/file/tip/ext/background.js#l330 here] perhaps I can check the error message at the start of the catch and silence the error? Should avoid common case handling too. 
     2 
     3EDIT: 
     4That's exception handling whoops, but adding a callback to the setIcon call which reads `browser.runtime.lastError` works and avoids running the check on all set* but doesn't avoid it for common setIcon case.