Opened 6 months ago

Last modified 6 months ago

#6495 new defect

ABP should suggest more specific hiding filters

Reported by: mapx Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: mjethani, kzar, hfiguiere, greiner, agiammarchi, athornburgh, jeen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mapx)

Environment

w10
last ABP dev build: 3.0.2.1983
chrome 66

How to reproduce

  • go to http://axistrivia.altervista.org/_test1.html
  • try to hide the third element on page (click ABP icon, block element, select the entire row - otherwise a blocking filter will be suggested)

Observed behaviour

  • a hiding filter is proposed: axistrivia.altervista.org##.column
  • the filter will hide all the elements on page

Expected behaviour

ABP should suggest a positional filter:
axistrivia.altervista.org##.column:nth-of-type(3)

Attachments (1)

create filters uBo.png (12.4 KB) - added by mapx 6 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 months ago by mapx

  • Cc greiner agiammarchi added

comment:2 Changed 6 months ago by mapx

  • Description modified (diff)
  • Summary changed from ABP should propose more specific hiding filters to ABP should suggest more specific hiding filters

comment:3 follow-up: Changed 6 months ago by kzar

  • Cc athornburgh jeen added
  • Component changed from Platform to User-Interface

I think this is another example of why the "block element" tool needs to provide a way for the user to make the suggested filter more or less specific. I'm not exactly how the UI should look here, in some situations the user might want to select the parent / child element but in other situations (like this one) things get more complicated.

comment:4 in reply to: ↑ 3 Changed 6 months ago by greiner

Replying to kzar:

I think this is another example of why the "block element" tool needs to provide a way for the user to make the suggested filter more or less specific. I'm not exactly how the UI should look here, in some situations the user might want to select the parent / child element but in other situations (like this one) things get more complicated.

I agree that we need to be careful not to make filters we suggest too specific as long as there's no easy way for users to modify them.

On the other hand, removing parts of a filter is easier than adding new parts so it may be sufficient for now to make sure that we highlight all matching elements whenever the filters change.
I think spec#140 may provide a good foundation for that since it mentions "Live preview of changes - give feedback in real time when the suggested filter is edited by the user so they know which element would be hidden/blocked."

Changed 6 months ago by mapx

comment:5 Changed 6 months ago by mapx

see the attached image what is suggesting uBo:

  • first pic ==> when the image is selected a blocking filter and cosmetic (hiding) filters are suggested
  • second pic ==> when the entire row (with the image) is selected ==> only a hiding filter is suggested

So, you could see how uBo is managing such feature

(sure, is suggesting the correct positional filter and the preview feature is doing its job)

Last edited 6 months ago by mapx (previous) (diff)
Note: See TracTickets for help on using tickets.