Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#65 closed change (fixed)

[ABP IE 1.1 cleanup] Fix the approach used by ieFirstRun.js

Reported by: trev Assignee: oleksandr
Priority: P3 Milestone: Adblock-Plus-1.2-for-Internet-Explorer
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr@… Blocked By:
Blocking: #58 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4859491858251776/

Description

Background

See #58.

What to change

Fix the approach used by ieFirstRun.js - http://codereview.adblockplus.org/11276031/diff/1/html/static/js/ieFirstRun.js#newcode49

Change History (12)

comment:1 Changed 5 years ago by philll

  • Blocking 58 added

comment:2 Changed 5 years ago by trev

  • Reporter changed from philll to trev

comment:3 Changed 5 years ago by fhd

  • Priority changed from Unknown to P3
  • Status changed from new to accepted

comment:4 Changed 5 years ago by fhd

  • Owner oleksandr deleted
  • Status changed from accepted to assigned

comment:5 Changed 5 years ago by fhd

  • Status changed from assigned to accepted

comment:6 Changed 5 years ago by philll

  • Status changed from accepted to new

comment:7 Changed 5 years ago by oleksandr

  • Cc oleksandr@… added
  • in_progress set to 0
  • Owner set to oleksandr
  • Ready unset
  • Review URL(s) modified (diff)
  • Status changed from new to assigned

comment:8 Changed 5 years ago by philll

  • Ready set

comment:9 Changed 5 years ago by philll

  • Status changed from assigned to new

The assigned state will be dropped by #403

comment:10 Changed 5 years ago by oleksandr

  • Platform set to Unknown
  • Status changed from new to reviewing

comment:11 Changed 5 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.2
Note: See TracTickets for help on using tickets.