Opened 19 months ago

Closed 7 weeks ago

#6505 closed change (rejected)

Make use of default function parameters in Core module

Reported by: mjethani Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: erikvold Blocked By:
Blocking: #6445 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29714606/

Description

Background

See #6445.

What to change

Find instances in the code where it would benefit from the use of default function parameters and make the appropriate changes.

Change History (3)

comment:1 Changed 19 months ago by abpbot

A commit referencing this issue has landed:
Issue 6505 - Make selector parameter in makeSelector optional

comment:2 Changed 11 months ago by erikvold

  • Cc erikvold added

comment:3 Changed 7 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.