Changes between Version 8 and Version 9 of Ticket #6511


Ignore:
Timestamp:
03/23/2018 04:29:51 PM (18 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6511 – Description

    v8 v9  
    4545In the 3.0.2 release, selecting [Close this notification] removes the notification from the UI and it is not present when the popup ui is reopened. The same with [Stop showing notifications]. 
    4646 
     47=== What to change === 
     48 - Update the adblockplusui dependency to `hg:9546f62e182f git:7411639` which will include the fixes for #6511 and #6510. 
     49 - Send a "notifications.clicked" message instead of calling `notification.onClicked()` from the popup code. 
     50 - Implement `notificationHelpre.notificationClicked`. 
     51 
    4752=== Notes === 
    4853- This regression was caused by [https://hg.adblockplus.org/adblockpluschrome/rev/5f567fd2a52a ​Issue 5593 - Use messaging for the popup's notification code]. 
    4954- [https://hg.adblockplus.org/adblockpluschrome/rev/5f567fd2a52a#l2.138 Seems like this line is the problem]. We'll need to send a message back instead of attempting to call  `notification.onClicked()`. 
    5055- This fix will update the `adblockplusui` dependency, pulling in #6510 and #6512. 
     56 
     57=== Hints for testers === 
     58 - Test that #6511 and #6510 are fixed. 
     59 - No other changes are included, so nothing else should need to be tested.