Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#6512 closed change (fixed)

Add notifications.clicked message listener

Reported by: kzar Assignee: kzar
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By:
Blocking: #6511 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29730608/

Description (last modified by kzar)

Background

With #5593 we began using messaging in the popup's notification code, unfortunately we forgot about the notification's onClick() method, which caused the symptoms documented in #6511.

What to change

Add the "notifications.clicked" message handler. It should call the notificationHelper.notificationClicked() function with no arguments.

Integration notes

Add the notificationHelper.notificationClicked() function (see #6511).

Change History (7)

comment:1 Changed 17 months ago by kzar

  • Blocking 6511 added

comment:2 Changed 17 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 17 months ago by abpbot

A commit referencing this issue has landed:
Issue 6512 - Add notifications.clicked listener

comment:4 Changed 17 months ago by kzar

  • Priority changed from Unknown to P1
  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed

(Marking this as P1 since it blocks a P1 issue, marking it as Ready since it already passed review and landed.)

comment:5 Changed 17 months ago by kzar

  • Description modified (diff)

comment:6 Changed 17 months ago by sebastian

  • Blocking 6476 added

comment:7 Changed 17 months ago by sebastian

  • Blocking 6476 removed
Note: See TracTickets for help on using tickets.