Opened 20 months ago

Closed 18 months ago

Last modified 15 months ago

#6514 closed change (fixed)

IOToggle Custom Element

Reported by: agiammarchi Assignee: agiammarchi
Priority: Unknown Milestone:
Module: User-Interface Keywords: UI, UX, component
Cc: greiner, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29730644/
https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/12

Description (last modified by saroyanm)

Background

We agreed on moving away from the current monolith approach to a more flexible, easier to debug, test, or update, components for our common needs.

Now that https://issues.adblockplus.org/ticket/6487 has been merged, it's time to start creating accessible Custom Elements for all new UI components we need (language list, tooltip, infinite filters, etc).

Being a fresh new approach, I suggest we start from most basic elements, trying to improve all of them for both development and for UX experience.

What to do

Convert existing Toggle element into a separate component.

Change History (7)

comment:1 Changed 20 months ago by agiammarchi

  • Cc greiner saroyanm added

comment:2 Changed 18 months ago by saroyanm

  • Description modified (diff)
  • Summary changed from [meta] Create Accessible UI Components to IOToggle Custom Element

Changed the description to reflect the change we are planing to land into the release.

comment:3 Changed 18 months ago by saroyanm

  • Owner set to agiammarchi

comment:4 Changed 18 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 18 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 18 months ago by abpbot

A commit referencing this issue has landed:
Issue 6514 - IOToggle Custom Element

comment:7 Changed 15 months ago by greiner

See also #5900

Note: See TracTickets for help on using tickets.