#6524 closed change (fixed)

Start libadblockplus-ios framework

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29733719/

Description

Background

As discussed in meetings and documented in https://docs.google.com/document/d/1Hznm0Jp90HS81ns-BykHw7a38WYkizSyZ1Qn-vQP71c/edit#heading=h.31y35xg69nuu, we are creating a framework to include certain functionality found in ABP Safari iOS.

What to change

Add a framework target to ABP.

Change History (4)

comment:1 Changed 21 months ago by dzhang

  • Component changed from Unknown to Adblock-Plus-for-iOS
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 21 months ago by CraftyDeano

Worth noting that the implementation of adding content blockers to WKWebKit is slightly different from the SFContentBlocker API so while there is a lot of overlap, there would be some extra work involved for this framework to support both of the API's. If you want more details about the differences, just LMK.

comment:3 Changed 21 months ago by dzhang

Thanks @craftydeano - this is good to keep in mind when we handle the content blocker.

comment:4 Changed 21 months ago by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.