Changes between Version 15 and Version 17 of Ticket #6526


Ignore:
Timestamp:
06/21/2018 01:56:10 PM (18 months ago)
Author:
hfiguiere
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6526 – Description

    v15 v17  
    88- look into `v8::Script::Compile`, related #6448 
    99- [done] use `v8::Local` instead of `v8::Handle` 
     10- [done] use ''maybe'' version of `v8::Message::GetLineNumber` 
    1011- [question is below] use v8 functions which return ''maybe'' values, e.g. 
    1112 - `v8::Value::IntegerValue` 
     
    1617 - `v8::Object::GetOwnPropertyNames` 
    1718 - `v8::Function::Call` 
    18  - `v8::Message::GetLineNumber` 
    1919 - etc 
    2020- those ''maybe'' functions accept `v8::Context`, therefore we need to carefully check that we pass the correct context. Perhaps in the callbacks we should rather use `v8::Isolate::GetCurrentContext` instead of obtaining it from `JsEngine`. Additionally pay attention to `JsContext` which works with the context too.