Opened 20 months ago

Last modified 15 months ago

#6526 new change

Stop using of deprecated V8 API. — at Version 1

Reported by: sergz Assignee:
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: rjeschke, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29734562/
https://codereview.adblockplus.org/29735555/
https://codereview.adblockplus.org/29809555/
https://codereview.adblockplus.org/29810586/
https://codereview.adblockplus.org/29812646/
https://codereview.adblockplus.org/29812649/
https://codereview.adblockplus.org/29813591/
https://gitlab.com/eyeo/adblockplus/libadblockplus/merge_requests/7
https://gitlab.com/eyeo/adblockplus/libadblockplus/merge_requests/9

Description

Background

We are using pretty a lot of deprecated V8 API, and in order to simplify our life, avoid unnecessary delays in such issues like #6063, and be able to experiment with new techniques like WebAssembly, we should update our code base to use up-to-date API.

What to change

The list of API

  • v8::TryCatch should accept v8::Isolate
  • v8::Isolate::IdleNotification is renamed to v8::Isolate::IdleNotitifcationDeadline
  • look into v8::Script::Compile, related #6448
  • to be continued ...

Change History (1)

comment:1 Changed 20 months ago by sergz

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.