Opened 3 weeks ago

Closed 15 hours ago

#6531 closed change (fixed)

Update v8 to 6.5.254.41 in libadblockplus

Reported by: sergz Assignee: sergz
Priority: P1 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov Blocked By:
Blocking: #6588 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29747555/
https://codereview.adblockplus.org/29748587/

Description

Background

We have to support V8 from chromium 65 (related issue #6063).

According to https://omahaproxy.appspot.com/ the current stable versions for desktop and android of chrome use V8 6.5.254.41 and 6.5.254.28.

What to change

Basically #5503 should be a blocker, and as it's said in #6063#comment:12 one should rather switch to GN to build V8.
Additionally update NDK to r16b.

Additional checks

Check how it works with the previous versions of V8. Theoretically it can be possible to build them using C++14 and new NDK if we don't use gyp.

Additional notes

However, since there is a huge pressure we will firstly evaluate the approach described above and if there is no chance to get it done soon enough then just proceed with a temporary hacky solution, perhaps even in a branch for chromium.
For the beginning it seems there will no any libadblockplus-v8-project, the everything will reside in libadblockplus repository for the sake of convenience.

Change History (4)

comment:1 Changed 10 days ago by sergz

  • Review URL(s) modified (diff)

Add the codereview for V8.

comment:2 Changed 9 days ago by sergz

  • Review URL(s) modified (diff)

Because of the time pressure it's done (in review) however we should start to work ASAP on #5503, switching to GN to build V8, and updating to the next version of V8 for the next release of chromium.

Switching to meson in libadblockplus is not a blocker right now, though it can make the configuration cleaner and it seems a good opportunity to work on it while we are on the adjacent tasks.

comment:3 Changed 3 days ago by asmirnov

  • Blocking 6588 added

comment:4 Changed 15 hours ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.