Opened 2 years ago

Closed 23 months ago

Last modified 19 months ago

#6532 closed change (fixed)

Remove subscription title input field when adding filterlists by url

Reported by: jsonesen Assignee: jsonesen
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by greiner)


Currently when subscribing to a new filterlist the user is required to enter a title for the name of the list, but once the subscription is added the title input by our users is overwritten by the title given to the list by the authors.

See also

What to change

  • Remove the input field for the filter list title from desktop-options.html and update any parts in the code that refer to it
  • Remove the strings "options_dialog_import_subscription_title" and "options_dialog_import_subscription_title_error"

Change History (12)

comment:1 Changed 2 years ago by jsonesen

  • Description modified (diff)

comment:2 Changed 2 years ago by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by sebastian

  • Cc sebastian added

comment:4 Changed 2 years ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed 23 months ago by jsonesen

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
Issue 6532 - Removes required subscription title input field

comment:8 Changed 21 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Appears to be working as expected.

Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7

comment:9 Changed 21 months ago by Ross

Something I did notice while testing this however: The title=<> param from an abp:subscribe link takes precedence over any title set in the subscription file itself (using ! Title: <>). Is that correct?

comment:10 Changed 21 months ago by greiner

No, it shouldn't. The title provided within the filter list should always take precedence so thanks for pointing that out.

Mind creating a ticket for that issue?

comment:11 follow-up: Changed 19 months ago by SMed79

Are you planning to remove the input field for the filter list title from "_mobile-options.html_"?

comment:12 in reply to: ↑ 11 Changed 19 months ago by greiner

Replying to SMed79:

Are you planning to remove the input field for the filter list title from "_mobile-options.html_"?

Yes and no.

The title input field has been removed in #6760 which is going to be included in the next update.

We do, however, keep showing the title when adding a language filter list as those use the same dialog. This is just a temporary solution though because removing it would require changing the user flow there to avoid the dialog.
There are no plans yet on whether or not this should be done so feel free to suggest an approach in a new ticket.

Note: See TracTickets for help on using tickets.