Opened 5 months ago

Closed 3 months ago

Last modified 5 weeks ago

#6532 closed change (fixed)

Remove subscription title input field when adding filterlists by url

Reported by: jsonesen Assignee: jsonesen
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29736629/

Description (last modified by greiner)

Background

Currently when subscribing to a new filterlist the user is required to enter a title for the name of the list, but once the subscription is added the title input by our users is overwritten by the title given to the list by the authors.

See also https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/38

What to change

  • Remove the input field for the filter list title from desktop-options.html and update any parts in the code that refer to it
  • Remove the strings "options_dialog_import_subscription_title" and "options_dialog_import_subscription_title_error"

Change History (10)

comment:1 Changed 5 months ago by jsonesen

  • Description modified (diff)

comment:2 Changed 5 months ago by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 months ago by sebastian

  • Cc sebastian added

comment:4 Changed 4 months ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed 3 months ago by jsonesen

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 6532 - Removes required subscription title input field

comment:8 Changed 5 weeks ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Appears to be working as expected.

ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7

comment:9 Changed 5 weeks ago by Ross

Something I did notice while testing this however: The title=<> param from an abp:subscribe link takes precedence over any title set in the subscription file itself (using ! Title: <>). Is that correct?

comment:10 Changed 5 weeks ago by greiner

No, it shouldn't. The title provided within the filter list should always take precedence so thanks for pointing that out.

Mind creating a ticket for that issue?

Note: See TracTickets for help on using tickets.