Opened 2 years ago

Last modified 21 months ago

#6532 closed change

Remove subscription title input field when adding filterlists by url — at Version 4

Reported by: jsonesen Assignee: jsonesen
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29736629/

Description (last modified by greiner)

Background

Currently when subscribing to a new filterlist the user is required to enter a title for the name of the list, but once the subscription is added the title input by our users is overwritten by the title given to the list by the authors.

See also https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/38

What to change

  • Remove the input field for the filter list title from desktop-options.html and update any parts in the code that refer to it
  • Remove the strings "options_dialog_import_subscription_title" and "options_dialog_import_subscription_title_error"

Change History (4)

comment:1 Changed 2 years ago by jsonesen

  • Description modified (diff)

comment:2 Changed 2 years ago by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by sebastian

  • Cc sebastian added

comment:4 Changed 2 years ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set
Note: See TracTickets for help on using tickets.