Opened 14 months ago

Closed 14 months ago

Last modified 13 months ago

#6536 closed change (fixed)

Separate AdblockChromium files and SDK libraries files

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: diegocarloslima Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/11

Description (last modified by asmirnov)

Background

We've added build config files (BUILD.gn) and some other files (python hooks) in third_party/libadblockplus, third_party/libadblockplus_common and third_party/libadblockplus_android. However we also clone libs sources to the same directories directly. So we're mixing files from AdblockPlusChromium repository and from github libraries repositories. It makes git status show files from AdblockPlusChromium repository showing as untracked files.

The good practise is to checkout libraries files to src subdirectories and exclude them from git tracking (.gitignore) in AdblockPlusChromium repository. It will simplify gclient sync too.

What to change

Checkout paths and build configs to use src for libraries files checked out from Github.

Tips for testers

Since it does not relate to any feature it's hard to test it (i'd say you can't test if you are not developer).
If Chromium can be compiled and launched it means it did not break it at least.

Change History (5)

comment:1 Changed 14 months ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 14 months ago by asmirnov

Duplicates #6535

comment:3 Changed 14 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 14 months ago by asmirnov

Since now they libadblockplus and libadblockplus-android are now extracted to src subdirectories i'd suggest to clean third_party/libadblockplus and third_party/libadblockplus_android, check out them again and then gclient sync.

comment:5 Changed 13 months ago by asmirnov

  • Description modified (diff)
Note: See TracTickets for help on using tickets.