Opened 5 years ago

Closed 5 years ago

#654 closed change (fixed)

Store pages in their tabs to improve performance on Safari

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: philll Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5359707120205824

Description (last modified by philll)

Background

In order to deal with pre-rendered pages, we started to use IDs internally to identify pages regardless of their tab. However in some situations there is no way to get the pageId. So we currently iterate over all pages to find (the hopefully correct) page for the given tab. However checking every page is rather slow, and degrades performance in particular when having a lot of pages opened at the same time.

What to change

Attach pages to their SafariBrowserTab object.

Hints for testers

  • Make sure that all ads are blocked as before.
  • Make sure that pre-rendered pages are still handled properly.
  • Make sure that the ad counter shows the correct value for the current page.
  • Make sure that the icon badge updates correctly when switching between tabs.
  • You only have to test on Safari. The changed code isn't even included in the Chrome and Opera build.

Change History (4)

comment:1 Changed 5 years ago by sebastian

  • Cc philll added

I had to wrap the description into a code block to work around SpamBayes.

comment:2 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by philll

  • Description modified (diff)

I trained SpamBayes to acknowledge this as non-spam.

comment:4 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.