Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#6542 closed defect (fixed)

Blocked / whitelisted URLs are not coloured red / green in devtools panel

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Ross, sebastian, greiner, saroyanm, agiammarchi Blocked By:
Blocking: #6548 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29738571/

Description (last modified by kzar)

Environment

Adblock Plus devbuild from 7eeecf6e1a1d, Chrome 65, EasyList (AA disabled).

How to reproduce

  1. Open a new tab, open the developer tools for it and switch to the Adblock Plus pane.
  2. Select "Blocked" to view only blocked requests
  3. Browse to https://reddit.com

Observed behaviour

While the blocked requests are mostly coloured red, the URL isn't. (See screenshot attached.)

Expected behaviour

The URL should be coloured red too.

Notes

  • This is a regression from d414ee80d886.
  • It also applies to whitelisted requests.

Hints for testers

Test that the colours of blocked, whiteslisted and regular resources all look correct in our developer tools pane. Test with both the regular and dark theme.

Attachments (1)

blocked-url-colour.png (68.2 KB) - added by kzar 21 months ago.

Download all attachments as: .zip

Change History (9)

Changed 21 months ago by kzar

comment:1 Changed 21 months ago by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 21 months ago by greiner

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 21 months ago by kzar

  • Blocking 6518 added

comment:4 Changed 21 months ago by abpbot

A commit referencing this issue has landed:
Issue 6542 - Fix the colours of the devtools resource URLs

comment:5 Changed 21 months ago by kzar

  • Blocking 6548 added

comment:6 Changed 21 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 21 months ago by kzar

  • Blocking 6518 removed

comment:8 Changed 21 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

ABP 3.0.2.2002
Firefox 51 / 58 / Windows 7
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Note: See TracTickets for help on using tickets.