Opened 3 weeks ago

Closed 2 weeks ago

#6543 closed change (fixed)

Match requests without tabId/frameId in their originating context

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-for-Chrome-Opera-Firefox-next
Module: Platform Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29739594

Description

Background

Currently, requests that don't relate to any tab or frame (e.g. requests sent by Service/Shared Workers) are matched out of context. This means the $domain filter option doesn't work, neither does document-based whitelisting. However, Firefox and Chrome >=63, now, provide information about the origin of the request through the orignUrl (Firefox) and initiator (Chrome) properties, even if no tabId is assigned.

What to change

Fall back to originUrl on Firefox, and initiator on Chrome, when either the tabId or frameId is set to -1. So that the $domain filter option as well as document-based whitelisting (including $sitekey) work for requests sent from Service Workers (and other scenarios where no tab is associated).

Change History (4)

comment:1 Changed 3 weeks ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 weeks ago by greiner

  • Cc greiner added

comment:4 Changed 2 weeks ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.